Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DataType::Utf8 #1605

Closed
wants to merge 1 commit into from
Closed

Remove DataType::Utf8 #1605

wants to merge 1 commit into from

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented Aug 25, 2021

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

  • Remove DataType::Utf8
  • Rename DataType::Binary to be DataType::String, DataType::String is the logic datatype of DataType::LargeBinary in arrow.
  • Refactor other functions to work with DataType::String

Changelog

  • New Feature

Related Issues

Fixes #1603

@databend-bot databend-bot added the pr-feature this PR introduces a new feature to the codebase label Aug 25, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot
Copy link
Member

Hello @zhyass, 🎉 Thank you for opening the pull request! 🎉
Your pull request state is not in Draft, please add Reviewers or Re-request review again!
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky
Or visit datafuse roadmap for some clues.

@zhyass zhyass marked this pull request as draft August 25, 2021 14:27
@zhyass zhyass closed this Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Refactors types] Remove DataType::Utf8
2 participants
@zhyass @databend-bot