Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DataType::Utf8 #1606

Merged
merged 4 commits into from
Sep 2, 2021
Merged

Remove DataType::Utf8 #1606

merged 4 commits into from
Sep 2, 2021

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented Aug 25, 2021 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

Changelog

  • New Feature

Related Issues

Fixes #1603

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot databend-bot added the pr-feature this PR introduces a new feature to the codebase label Aug 25, 2021
@databend-bot
Copy link
Member

Hello @zhyass, 🎉 Thank you for opening the pull request! 🎉
Your pull request state is not in Draft, please add Reviewers or Re-request review again!
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky
Or visit datafuse roadmap for some clues.

@zhyass zhyass marked this pull request as draft August 25, 2021 14:37
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2021 •
edited
Loading

Codecov Report

Merging #1606 (7fc1d54) into master (cbd8a3c) will increase coverage by 0%.
The diff coverage is 75%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #1606    +/-   ##
=======================================
  Coverage      72%     72%            
=======================================
  Files         578     574     -4     
  Lines       34010   33851   -159     
=======================================
- Hits        24594   24570    -24     
+ Misses       9416    9281   -135
Impacted Files Coverage Δ
common/datavalues/src/arrays/arithmetic.rs 27% <0%> (ø)
common/datavalues/src/arrays/ops/apply.rs 85% <ø> (ø)
common/datavalues/src/arrays/ops/cast.rs 41% <0%> (+1%) ⬆️
common/datavalues/src/arrays/ops/contain.rs 100% <ø> (ø)
common/datavalues/src/arrays/ops/take_single.rs 29% <ø> (ø)
common/datavalues/src/arrays/trusted_len.rs 100% <ø> (ø)
common/datavalues/src/data_group_value.rs 25% <0%> (ø)
common/datavalues/src/data_value_ops.rs 40% <0%> (ø)
common/datavalues/src/series/arithmetic.rs 65% <ø> (ø)
common/datavalues/src/types/data_df_type.rs 20% <0%> (ø)
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbd8a3c...7fc1d54. Read the comment docs.

sundy-li
sundy-li reviewed Sep 2, 2021
View reviewed changes
query/src/sessions/settings.rs Outdated
("flight_client_timeout", u64, 60, "Max duration the flight client request is allowed to take in seconds. By default, it is 60 seconds".to_string()),
("min_distributed_rows", u64, 100000000, "Minimum distributed read rows. In cluster mode, when read rows exceeds this value, the local table converted to distributed query.".to_string()),
("min_distributed_bytes", u64, 500 * 1024 * 1024, "Minimum distributed read bytes. In cluster mode, when read bytes exceeds this value, the local table converted to distributed query.".to_string())
("max_block_size", u64, 10000, "Maximum block size for reading".as_bytes().to_vec()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just keep it as &str.

we can modify inside the pub fn try_set_xx functions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@zhyass
Copy link
Member Author

zhyass commented Sep 2, 2021 •
edited
Loading

Wait the pr jorgecarleitao/arrow2#346 complete

@zhyass zhyass marked this pull request as ready for review September 2, 2021 13:02
@sundy-li
Copy link
Member

sundy-li commented Sep 2, 2021

Wait the pr jorgecarleitao/arrow2#346 complete

No need to wait, we can review and merge in previous and update the commit in another pr.

@zhyass
Copy link
Member Author

zhyass commented Sep 2, 2021

No need to wait, we can review and merge in previous and update the commit in another pr.

Sure, opened

sundy-li
sundy-li approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@sundy-li sundy-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit 6822281 into databendlabs:master Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Refactors types] Remove DataType::Utf8
4 participants
@zhyass @databend-bot @codecov-commenter @sundy-li