[deps] bump prost & tonic #1616
Conversation
Signed-off-by: Chojan Shang <[email protected]>
databend-bot
added
pr-build
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
|
Hello @PsiACE, 🎉 Thank you for opening the pull request! 🎉 |
|
This PR is ready. Of course we can also wait for arrow2. |
common/arrow/Cargo.toml
Outdated
| @@ -15,8 +15,8 @@ simd = ["arrow/simd"] | |||
| # Workspace dependencies | |||
|
|
|||
| # Github dependencies | |||
| arrow = { package = "arrow2", git="https://github.com/datafuse-extras/arrow2", rev = "43c101f" } | |||
| arrow-flight = { git="https://github.com/datafuse-extras/arrow2", rev = "43c101f" } | |||
| arrow = { package = "arrow2", git="https://github.com/psiace/arrow2", rev = "5187d3d" } | |||
There was a problem hiding this comment.
😎, why not using the datafuse-extra branch here?
What's the difference between them?
There was a problem hiding this comment.
It seems that I still need to solve the problem of arrow2 integration test, although it can already be used in our project :(
There was a problem hiding this comment.
Hmm, how about wait the arrow2 merged or patch it to the datafuse-extra/arrow2?
There was a problem hiding this comment.
| metadata.insert_bin(AUTH_TOKEN_KEY, MetadataValue::from_bytes(&token)); | ||
| Ok(req) | ||
| }) | ||
| FlightServiceClient::with_interceptor(channel, AuthInterceptor { token }) |
Signed-off-by: Chojan Shang <[email protected]>
|
Once merged, we can enable |
Codecov Report
@@ Coverage Diff @@
## master #1616 +/- ##
======================================
Coverage 73% 73%
======================================
Files 540 540
Lines 33465 33468 +3
======================================
+ Hits 24436 24444 +8
+ Misses 9029 9024 -5
Continue to review full report at Codecov.
|
|
CI Passed |
Signed-off-by: Chojan Shang [email protected]
I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/
Summary
Changelog
Related Issues
Fixes #1090 #1027
Test Plan
Unit Tests
Stateless Tests