Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed send and sync for mutex and rwlock #1705

Merged
merged 4 commits into from
Sep 3, 2021

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Sep 2, 2021

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

Implement send and sync for all type is unsafe(our previous understanding of send and sync is problematic)

Thanks jorgecarleitao/arrow2#368 (comment)

Changelog

  • Bug Fix

@databend-bot databend-bot added the pr-bugfix this PR patches a bug in codebase label Sep 2, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #1705 (e66bacf) into master (cbd8a3c) will increase coverage by 0%.
The diff coverage is 62%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #1705    +/-   ##
=======================================
  Coverage      72%     72%            
=======================================
  Files         578     574     -4     
  Lines       34010   33882   -128     
=======================================
- Hits        24594   24577    -17     
+ Misses       9416    9305   -111     
Impacted Files Coverage Δ
common/infallible/src/mutex.rs 100% <ø> (ø)
common/infallible/src/rwlock.rs 82% <ø> (ø)
.../pipelines/transforms/group_by/aggregator_state.rs 20% <30%> (ø)
...ry/src/pipelines/transforms/group_by/aggregator.rs 83% <68%> (-4%) ⬇️
common/streams/src/sources/source_csv.rs 93% <100%> (-1%) ⬇️
common/streams/src/sources/source_values.rs 96% <100%> (ø)
...pipelines/transforms/transform_group_by_partial.rs 74% <100%> (-1%) ⬇️
common/datavalues/src/data_value.rs 45% <0%> (-3%) ⬇️
common/datavalues/src/types/mod.rs 33% <0%> (-3%) ⬇️
query/src/interpreters/interpreter_explain.rs 53% <0%> (-2%) ⬇️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbd8a3c...e66bacf. Read the comment docs.

@zhang2014 zhang2014 marked this pull request as ready for review September 3, 2021 02:15
@databend-bot
Copy link
Member

Hello @zhang2014, 🎉 Thank you for opening the pull request! 🎉
Your pull request state is not in Draft, please add Reviewers or Re-request review again!
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky
Or visit datafuse roadmap for some clues.

@zhang2014 zhang2014 requested a review from sundy-li September 3, 2021 02:15
@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit 163821c into databendlabs:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants