Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix cargo check #17152

Merged
merged 2 commits into from
Jan 2, 2025
Merged

chore: fix cargo check #17152

merged 2 commits into from
Jan 2, 2025

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Jan 2, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

If not add features client and TCP, will return error when run cargo c --timings under src/query/functions

➜  functions git:(main) ✗ cargo c --timings        
warning: patch for `backtrace` uses the features mechanism. default-features and features will not take effect because the patch dependency does not support this mechanism
    Checking databend-common-hashtable v0.1.0 (/data1/eason/databend/src/common/hashtable)
    Checking databend-common-grpc v0.1.0 (/data1/eason/databend/src/common/grpc)
    Checking databend-common-openai v0.1.0 (/data1/eason/databend/src/common/openai)
error[E0433]: failed to resolve: could not find `client` in `hyper_v014`
   --> src/common/grpc/src/dns_resolver.rs:35:17
    |
35  | use hyper_v014::client::connect::dns::Name as Hyperv014Name;
    |                 ^^^^^^ could not find `client` in `hyper_v014`
    |
note: found an item that was configured out
   --> /home/eason/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-0.14.30/src/lib.rs:100:13
    |
100 |     pub mod client;
    |             ^^^^^^
note: the item is gated behind the `client` feature
   --> /home/eason/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-0.14.30/src/lib.rs:98:8
    |
98  |     #![feature = "client"]
    |        ^^^^^^^

For more information about this error, try `rustc --explain E0433`.
error: could not compile `databend-common-grpc` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
      Timing report saved to /data1/eason/databend/target/cargo-timings/cargo-timing-20250102T033209Z.html


➜  functions git:(main) ✗ cargo c --timings
warning: patch for `backtrace` uses the features mechanism. default-features and features will not take effect because the patch dependency does not support this mechanism

    Blocking waiting for file lock on build directory
    Checking hyper v0.14.30
    Checking databend-common-grpc v0.1.0 (/data1/eason/databend/src/common/grpc)
error[E0432]: unresolved import `hyper_v014::client::connect::dns`
  --> src/common/grpc/src/dns_resolver.rs:35:34
   |
35 | use hyper_v014::client::connect::dns::Name as Hyperv014Name;
   |                                  ^^^ could not find `dns` in `connect`
   |
note: found an item that was configured out
  --> /home/eason/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-0.14.30/src/client/connect/mod.rs:96:13
   |
96 |     pub mod dns;
   |             ^^^
note: the item is gated behind the `tcp` feature
  --> /home/eason/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-0.14.30/src/client/connect/mod.rs:92:8
   |
92 |     #![feature = "tcp"]
   |        ^^^^^^^

For more information about this error, try `rustc --explain E0432`.
error: could not compile `databend-common-grpc` (lib) due to 1 previous error
      Timing report saved to /data1/eason/databend/target/cargo-timings/cargo-timing-20250102T033719Z.html

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@TCeason TCeason requested a review from dantengsky January 2, 2025 03:43
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 2, 2025
@dantengsky dantengsky added this pull request to the merge queue Jan 2, 2025
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Jan 2, 2025
@BohuTANG BohuTANG merged commit 29fcd98 into databendlabs:main Jan 2, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants