Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused settings for ssl #17173

Merged
merged 2 commits into from
Jan 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 0 additions & 14 deletions src/query/settings/src/settings_default.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1158,20 +1158,6 @@ impl DefaultSettings {
scope: SettingScope::Session,
range: None,
}),
("premise_deploy_danger_amend_accept_invalid_cert", DefaultSettingValue {
value: UserSettingValue::UInt64(0),
desc: "Setting this to a non-zero value will allow `fuse_amend` to accept invalid TLS certificates. For diagnostic purposes only, Be very cautious before setting this to a non-zero value. If you're unsure, leave it unchanged.",
mode: SettingMode::Both,
scope: SettingScope::Both,
range: Some(SettingRange::Numeric(0..=1)),
}),
("premise_deploy_amend_force_path_style", DefaultSettingValue {
value: UserSettingValue::UInt64(1),
desc: "Setting this to a non-zero value will let `fuse_amend` use path style uri while accessing s3-compatible storage service.",
mode: SettingMode::Both,
scope: SettingScope::Both,
range: Some(SettingRange::Numeric(0..=1)),
}),
]);

Ok(Arc::new(DefaultSettings {
Expand Down
8 changes: 0 additions & 8 deletions src/query/settings/src/settings_getter_setter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -853,12 +853,4 @@ impl Settings {
pub unsafe fn set_warehouse(&self, warehouse: String) -> Result<()> {
self.unchecked_set_setting(String::from("warehouse"), warehouse)
}

pub fn get_premise_deploy_danger_amend_accept_invalid_cert(&self) -> Result<bool> {
Ok(self.try_get_u64("premise_deploy_danger_amend_accept_invalid_cert")? != 0)
}

pub fn get_premise_deploy_amend_force_path_style(&self) -> Result<bool> {
Ok(self.try_get_u64("premise_deploy_amend_force_path_style")? != 0)
}
}
Loading