Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fix aggregating index conflict with min/max rewrite #17182

Merged
merged 11 commits into from
Jan 7, 2025

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Jan 6, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • Fix aggregating index conflict with min/max rewrite. Add derived columns for aggregating functions except min and max. Avoid failure to find aggregate function during aggregating Index rewriting.
  • Modify create aggregating index check criteria. An aggregate index must contain at least one of aggregate function, group by, or where selection. This is uesd to avoid creating a meaningless aggregating index, such as select a + 1 from t.

fixes: #17180

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@b41sh b41sh requested a review from sundy-li January 6, 2025 14:36
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jan 6, 2025
@b41sh b41sh added this pull request to the merge queue Jan 7, 2025
Merged via the queue into databendlabs:main with commit 53ce6b3 Jan 7, 2025
72 checks passed
@b41sh b41sh deleted the fix-agg-index-min-max branch January 7, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: aggregating index conflict with min/max rewrite
2 participants