Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): record state_rows in aggregate payload #17194

Merged
merged 6 commits into from
Jan 8, 2025
Merged

fix(query): record state_rows in aggregate payload #17194

merged 6 commits into from
Jan 8, 2025

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Jan 7, 2025 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix(query): initialize aggregate payload pages with zero value

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jan 7, 2025
@sundy-li sundy-li changed the title fix(query): initialize aggregate payload pages with zero value fix(query): record state_rows in aggregate payload Jan 7, 2025
@sundy-li sundy-li requested a review from zhang2014 January 8, 2025 02:16
@sundy-li sundy-li marked this pull request as ready for review January 8, 2025 02:16
@zhang2014 zhang2014 added the ci-benchmark Benchmark: run all test label Jan 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Docker Image for PR

  • tag: pr-17194-5e0b915-1736307198

note: this image tag is only available for internal use,
please check the internal doc for more details.

@wubx
Copy link
Member

wubx commented Jan 8, 2025

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

ClickBench Report

@sundy-li sundy-li added this pull request to the merge queue Jan 8, 2025
Merged via the queue into databendlabs:main with commit 64c53b2 Jan 8, 2025
90 checks passed
@sundy-li sundy-li deleted the Agg-payload-drop2 branch January 8, 2025 05:15
@sundy-li sundy-li mentioned this pull request Jan 13, 2025
Merged
11 tasks
sundy-li added a commit to sundy-li/databend that referenced this pull request Jan 13, 2025
@sundy-li
Revert "fix(query): record state_rows in aggregate payload (databendl…
96394fe 
…abs#17194)"

This reverts commit 64c53b2.
@sundy-li sundy-li mentioned this pull request Jan 13, 2025
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhang2014 zhang2014 zhang2014 approved these changes

Assignees
No one assigned
Labels
ci-benchmark Benchmark: run all test pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sundy-li @wubx @zhang2014