Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): load ndjson support ts with diff units. #17203

Merged
merged 5 commits into from
Jan 8, 2025
Merged

feat(query): load ndjson support ts with diff units. #17203

merged 5 commits into from
Jan 8, 2025

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Jan 8, 2025 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

loading ndjson now use the same function ( int64_to_timestamp ) as the cast function

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@youngsofun youngsofun requested a review from TCeason January 8, 2025 05:31
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jan 8, 2025
@youngsofun youngsofun force-pushed the fix_ndjson branch 5 times, most recently from aca9458 to a336655 Compare January 8, 2025 14:25
@youngsofun youngsofun added this pull request to the merge queue Jan 8, 2025
Merged via the queue into databendlabs:main with commit 069bdbb Jan 8, 2025
70 checks passed
@youngsofun youngsofun deleted the fix_ndjson branch January 8, 2025 16:25
sundy-li pushed a commit to sundy-li/databend that referenced this pull request Jan 9, 2025
@youngsofun @sundy-li
feat(query): load ndjson support ts with diff units. (databendlabs#17203
424e49d 
)

* feat(query): load ndjson/csv/tsv support ts with diff units.

* fix

* refactor

* refactor

* fix clippy
@sundy-li sundy-li mentioned this pull request Jan 9, 2025
Merged
11 tasks
youngsofun added a commit to youngsofun/databend that referenced this pull request Jan 10, 2025
@youngsofun
feat(query): load ndjson support ts with diff units. (databendlabs#17203
fc57c5c 
)

* feat(query): load ndjson/csv/tsv support ts with diff units.

* fix

* refactor

* refactor

* fix clippy
sundy-li pushed a commit that referenced this pull request Jan 10, 2025
@youngsofun @TCeason
feat(query): load ndjson support ts with diff units. (#17239)
9987c34 
* chore: Split functions crate into multi crates (#17133)

* chore: Split functions crate into multi crates

* split new crate databend-functions-scalar-arithmetic databend-functions-scalar-arithmetic-modulo databend-functions-scalar-datetime databend-functions-scalar-decimal-utils

* split numeric basic arithmetic and other bit arithmetic

* fix ut

* restore int/double arithmetic

* fix

* feat(query): load ndjson support ts with diff units. (#17203)

* feat(query): load ndjson/csv/tsv support ts with diff units.

* fix

* refactor

* refactor

* fix clippy

---------

Co-authored-by: TCeason <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TCeason TCeason TCeason approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youngsofun @TCeason