Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cluster): fix heartbeat self managed after network fail #17241

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Jan 10, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix(cluster): fix heartbeat self managed after network fail

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@zhang2014 zhang2014 requested a review from drmingdrmer January 10, 2025 03:53
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jan 10, 2025
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @zhang2014)


src/query/management/src/warehouse/warehouse_mgr.rs line 1018 at r1 (raw file):

                    })),
            }) => Ok(seq_v.seq),
            _ if matches!(node.node_type, NodeType::SelfManaged) => Ok(0),

Add comment explaining why to return Ok(0) if the reply is not a GetResponse?

Copy link
Member Author

@zhang2014 zhang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @drmingdrmer)


src/query/management/src/warehouse/warehouse_mgr.rs line 1018 at r1 (raw file):

Previously, drmingdrmer (张炎泼) wrote…

Add comment explaining why to return Ok(0) if the reply is not a GetResponse?

Done.

@zhang2014 zhang2014 requested a review from drmingdrmer January 10, 2025 05:29
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @zhang2014)

@zhang2014 zhang2014 enabled auto-merge January 10, 2025 12:26
@zhang2014 zhang2014 added this pull request to the merge queue Jan 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 10, 2025
@zhang2014 zhang2014 added this pull request to the merge queue Jan 10, 2025
Merged via the queue into databendlabs:main with commit 2e3e44f Jan 10, 2025
70 of 71 checks passed
@zhang2014 zhang2014 deleted the fix/heartbeat_self_managed branch January 10, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants