-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cluster): fix heartbeat self managed after network fail #17241
fix(cluster): fix heartbeat self managed after network fail #17241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @zhang2014)
src/query/management/src/warehouse/warehouse_mgr.rs
line 1018 at r1 (raw file):
})), }) => Ok(seq_v.seq), _ if matches!(node.node_type, NodeType::SelfManaged) => Ok(0),
Add comment explaining why to return Ok(0)
if the reply is not a GetResponse?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @drmingdrmer)
src/query/management/src/warehouse/warehouse_mgr.rs
line 1018 at r1 (raw file):
Previously, drmingdrmer (张炎泼) wrote…
Add comment explaining why to return
Ok(0)
if the reply is not a GetResponse?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @zhang2014)
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
fix(cluster): fix heartbeat self managed after network fail
Tests
Type of change
This change is