Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix gen next patch release #17281

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

everpcpc
Copy link
Member

@everpcpc everpcpc commented Jan 14, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 14, 2025
Copy link

what-the-diff bot commented Jan 14, 2025

PR Summary

  • Improved Clarity in Version Bumping Code

    • We made changes to the 'bump_version.js', focusing on refining how we handle version updates. This should not only make the version updating process straightforward but will also avoid potential errors. We did this by making variable names clearer - for instance, renaming the variable 'patch' to 'version'.
  • Enhancement of Pre-release Version Increment Logic

    • We revised the mechanism in incrementing the pre-release version number to be more accurate. This way, when a new version is in the works, the version number updates will precisely reflect where we are in our development stage. It was previously done by simply adding one (pv + 1), but now, we're adding one to the parsed version number (parseInt(version[4]) + 1).

@everpcpc everpcpc merged commit d1a4975 into databendlabs:main Jan 14, 2025
10 checks passed
@everpcpc everpcpc deleted the fix-release branch January 14, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant