Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: backport set cache capacity to rel/v1.2.636-rc8.2 #17343

Merged
merged 7 commits into from
Jan 22, 2025
Merged

chore: backport set cache capacity to rel/v1.2.636-rc8.2 #17343

merged 7 commits into from
Jan 22, 2025

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Jan 21, 2025 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

backports #17196 to release/v.1.2.636-rc8.2

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - use existing tests

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe): backports

This change is Reviewable

@dantengsky
chore: bring back function set_cache_capacity (databendlabs#17196)
9333dd7 
* chore:bring back func `set_cache_capacity`

* test cases

* revert config file

* tweak test case

* fix: use usize as bytes capacity

* tweak lock scope

* rename vars/methods of cache mgr
@dantengsky
resovle pick conflicts
3d56bfa
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 21, 2025
@dantengsky dantengsky changed the title chore: pick set cache capacity to rel/v1.2.636-rc8.2 chore: backport set cache capacity to rel/v1.2.636-rc8.2 Jan 21, 2025
@dantengsky dantengsky marked this pull request as ready for review January 22, 2025 12:32
@dantengsky dantengsky requested a review from SkyFan2002 January 22, 2025 12:32
@dantengsky dantengsky merged commit 63cf08b into databendlabs:release/v1.2.636-rc8.2 Jan 22, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkyFan2002 SkyFan2002 SkyFan2002 approved these changes

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dantengsky @SkyFan2002