Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add disable_list_batch for webhdfs #17345

Merged
merged 4 commits into from
Jan 22, 2025
Merged

feat: Add disable_list_batch for webhdfs #17345

merged 4 commits into from
Jan 22, 2025

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jan 21, 2025 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Add disable list batch for webhdfs.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@Xuanwo Xuanwo requested a review from drmingdrmer as a code owner January 21, 2025 06:05
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jan 21, 2025
@Xuanwo Xuanwo requested a review from youngsofun January 21, 2025 06:05
@Xuanwo Xuanwo added the ci-cloud Build docker image for cloud test label Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17345-848df18-1737442223

note: this image tag is only available for internal use,
please check the internal doc for more details.

@Xuanwo
Fix test
b73eef2 
Signed-off-by: Xuanwo <[email protected]>
drmingdrmer
drmingdrmer approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 14 of 14 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @youngsofun)

@Xuanwo Xuanwo enabled auto-merge January 21, 2025 07:28
@Xuanwo Xuanwo added this pull request to the merge queue Jan 22, 2025
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Jan 22, 2025
@BohuTANG BohuTANG merged commit 12414d3 into databendlabs:main Jan 22, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngsofun youngsofun youngsofun approved these changes

@drmingdrmer drmingdrmer drmingdrmer approved these changes

Assignees
No one assigned
Labels
ci-cloud Build docker image for cloud test pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xuanwo @drmingdrmer @youngsofun @BohuTANG