Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add username support for webhdfs #17350

Merged
merged 2 commits into from
Jan 22, 2025
Merged

feat: Add username support for webhdfs #17350

merged 2 commits into from
Jan 22, 2025

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jan 22, 2025 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Add user name support for webhdfs.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@Xuanwo Xuanwo requested a review from drmingdrmer as a code owner January 22, 2025 05:30
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jan 22, 2025
@Xuanwo
Fix test
28a59a6 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo added the ci-cloud Build docker image for cloud test label Jan 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17350-5c40f7f-1737526882

note: this image tag is only available for internal use,
please check the internal doc for more details.

@Xuanwo Xuanwo added this pull request to the merge queue Jan 22, 2025
Merged via the queue into databendlabs:main with commit 17226b8 Jan 22, 2025
78 checks passed
@Xuanwo Xuanwo deleted the add-user-name-in-webhdfs branch January 22, 2025 08:54
drmingdrmer
drmingdrmer reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed 17 of 17 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drmingdrmer drmingdrmer drmingdrmer left review comments

@flaneur2020 flaneur2020 flaneur2020 approved these changes

Assignees
No one assigned
Labels
ci-cloud Build docker image for cloud test pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xuanwo @drmingdrmer @flaneur2020