Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): disallow push down filters that use columns in window order by columns or function argument columns #17353

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix(query): disallow push down filters that use columns in window order by columns or function argument columns #17353

merged 1 commit into from
Jan 22, 2025

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Jan 22, 2025 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jan 22, 2025
@sundy-li sundy-li added this pull request to the merge queue Jan 22, 2025
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Jan 22, 2025
@BohuTANG BohuTANG merged commit 97e2381 into databendlabs:main Jan 22, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: incorrect filter pushdown cross the window QUALIFY
3 participants
@forsaken628 @sundy-li @BohuTANG