Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): Align TRIM functions semantically with Snowflake #17375

Merged
merged 3 commits into from
Feb 5, 2025
Merged

fix(query): Align TRIM functions semantically with Snowflake #17375

merged 3 commits into from
Feb 5, 2025
+128 −19

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Jan 27, 2025 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

https://docs.snowflake.com/en/sql-reference/functions/trim#examples

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jan 27, 2025
@forsaken628
fix
e9f9535 
Signed-off-by: coldWater <[email protected]>
@forsaken628
fix
c0d8c31 
Signed-off-by: coldWater <[email protected]>
@forsaken628 forsaken628 marked this pull request as ready for review February 5, 2025 01:55
@TCeason TCeason added this pull request to the merge queue Feb 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 5, 2025
@TCeason TCeason added this pull request to the merge queue Feb 5, 2025
@TCeason
Copy link
Collaborator

TCeason commented Feb 5, 2025

cc @soyeric128 doc needed

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 5, 2025
@forsaken628 forsaken628 added this pull request to the merge queue Feb 5, 2025
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Feb 5, 2025
@BohuTANG BohuTANG merged commit 19c0c73 into databendlabs:main Feb 5, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TCeason TCeason TCeason approved these changes

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Align TRIM Functions with Snowflake Syntax (TRIM, LTRIM, RTRIM)
4 participants
@forsaken628 @TCeason @sundy-li @BohuTANG