Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): support extract EPOCH from timestamp #17385

Merged
merged 4 commits into from
Feb 1, 2025
Merged

feat(query): support extract EPOCH from timestamp #17385

merged 4 commits into from
Feb 1, 2025

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Jan 29, 2025 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jan 29, 2025
@TCeason TCeason force-pushed the fix_17384 branch 2 times, most recently from 150b124 to b23dd38 Compare January 29, 2025 11:09
@TCeason TCeason requested review from sundy-li and zhang2014 January 29, 2025 11:11
@TCeason TCeason requested a review from sundy-li January 31, 2025 08:27
@sundy-li
Copy link
Member

Better to rewrite epoch(timestamp) ---> timestamp in binder type_checker

@TCeason
Copy link
Collaborator Author

TCeason commented Feb 1, 2025

type_checker

You mean try_rewrite_sugar_function?

@sundy-li
Copy link
Member

sundy-li commented Feb 1, 2025

You mean try_rewrite_sugar_function?

Yes

@TCeason
Copy link
Collaborator Author

TCeason commented Feb 1, 2025 •
edited
Loading

try_rewrite_sugar_function

We also have epoch(i64)->intervaltype in interval.rs. And we need to support extract( from interval_type). So impl a new function is suitable.

@TCeason TCeason added this pull request to the merge queue Feb 1, 2025
Merged via the queue into databendlabs:main with commit e76aabc Feb 1, 2025
71 checks passed
@TCeason TCeason deleted the fix_17384 branch February 1, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@zhang2014 zhang2014 Awaiting requested review from zhang2014

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Allow Extract EPOCH from timestamp
2 participants
@TCeason @sundy-li