Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): row fetch will be fetched by distinct block batch #17391

Merged
merged 4 commits into from
Feb 1, 2025

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Jan 31, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

chore(query): row fetch will be fetched by distinct block batch

If the distinct block num exceeds max_threads in row_fetcher, it will process and flush the states.

Tests

  • Unit Test
  • Logic Test (cover old tests)
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@sundy-li sundy-li requested review from Dousir9 and zhang2014 January 31, 2025 12:19
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 31, 2025
@sundy-li sundy-li added this pull request to the merge queue Feb 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 1, 2025
@sundy-li sundy-li merged commit 8dfab90 into databendlabs:main Feb 1, 2025
70 checks passed
@sundy-li sundy-li deleted the row_fetch_batch branch February 1, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants