Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fix lambda function bind column failed #17402

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Feb 3, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

We use the number of bound columns as the column index of the lambda column, but since the column index may be discontinuous, e.g. if there is a not null column in the join table, a new nullable wrapper is generated to replace the original column, and a new column index is generated. In this case, the parameter of lambda function will got a wrong column index and cause resolve lambda function fail, this PR fixes this bug.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@b41sh b41sh requested a review from sundy-li February 3, 2025 18:28
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Feb 3, 2025
@sundy-li sundy-li enabled auto-merge February 4, 2025 03:30
@sundy-li sundy-li added this pull request to the merge queue Feb 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2025
@BohuTANG BohuTANG merged commit 855ecc8 into databendlabs:main Feb 4, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: group checker incorrect
3 participants