Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fix months_between overflow error #17403

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Feb 4, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

create or replace table t(mine_date date, birth_date date);
insert into t values('2022-01-01', '2022-01-01'),('2022-01-01', '2022-02-01'),('2022-02-01', '2022-01-01');
SELECT MONTHS_BETWEEN(mine_date, birth_date) as demo_age FROM t GROUP BY mine_date;

return errirL

:) SELECT MONTHS_BETWEEN(mine_date, birth_date) as demo_age FROM t GROUP BY mine_date;
error: APIError: QueryFailed: [1104]attempt to multiply with overflow

SELECT max(MONTHS_BETWEEN(mine_date, birth_date))/12 as demo_age FROM t GROUP BY mine_date;
panicked at src/query/expression/src/utils/date_helper.rs:246:14:
called Result::unwrap() on an Err value: parameter 'days' with value 1 is not in the required range of -4371587..=2932896

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@TCeason TCeason requested review from b41sh and sundy-li February 4, 2025 12:45
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Feb 4, 2025
@sundy-li sundy-li added this pull request to the merge queue Feb 4, 2025
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Feb 4, 2025
@BohuTANG BohuTANG merged commit 9997961 into databendlabs:main Feb 4, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants