fix(query): fix months_between overflow error #17403
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
create or replace table t(mine_date date, birth_date date);
insert into t values('2022-01-01', '2022-01-01'),('2022-01-01', '2022-02-01'),('2022-02-01', '2022-01-01');
SELECT MONTHS_BETWEEN(mine_date, birth_date) as demo_age FROM t GROUP BY mine_date;
return errirL
:) SELECT MONTHS_BETWEEN(mine_date, birth_date) as demo_age FROM t GROUP BY mine_date;
error: APIError: QueryFailed: [1104]attempt to multiply with overflow
SELECT max(MONTHS_BETWEEN(mine_date, birth_date))/12 as demo_age FROM t GROUP BY mine_date;
panicked at src/query/expression/src/utils/date_helper.rs:246:14:
called
Result::unwrap()
on anErr
value: parameter 'days' with value 1 is not in the required range of -4371587..=2932896Tests
Type of change
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)