Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-2353 wrap progress stream in TransformSource #2354

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

sundy-li
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

wrap progress stream in TransformSource

Changelog

  • Improvement

Related Issues

Fixes #2353

Test Plan

Unit Tests

Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@sundy-li sundy-li requested a review from BohuTANG October 20, 2021 15:07
@codecov-commenter
Copy link

Codecov Report

Merging #2354 (d3f9b47) into main (12de166) will increase coverage by 0%.
The diff coverage is 80%.

Impacted file tree graph

@@          Coverage Diff           @@
##            main   #2354    +/-   ##
======================================
  Coverage     70%     71%            
======================================
  Files        631     633     +2     
  Lines      35337   35703   +366     
======================================
+ Hits       25043   25430   +387     
+ Misses     10294   10273    -21     
Impacted Files Coverage Δ
query/src/datasources/table/fuse/table_do_read.rs 81% <ø> (+1%) ⬆️
...rc/datasources/table/memory/memory_table_stream.rs 87% <75%> (-1%) ⬇️
query/src/datasources/table_func/numbers_stream.rs 95% <75%> (-1%) ⬇️
query/src/pipelines/transforms/transform_source.rs 73% <100%> (+<1%) ⬆️
metasrv/src/api/http_service.rs 14% <0%> (-62%) ⬇️
common/datavalues/src/arrays/ops/to_values.rs 0% <0%> (-10%) ⬇️
query/src/catalogs/impls/catalog/system_catalog.rs 77% <0%> (-8%) ⬇️
common/streams/src/stream_progress.rs 90% <0%> (-5%) ⬇️
metasrv/src/api/http_service_test.rs 64% <0%> (-4%) ⬇️
common/datavalues/src/columns/data_column.rs 69% <0%> (-4%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12de166...d3f9b47. Read the comment docs.

@BohuTANG
Copy link
Member

/lgtm

@databend-bot
Copy link
Member

Approved! Thank you for the PR @sundy-li

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@BohuTANG BohuTANG merged commit 8107725 into databendlabs:main Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap ProgressStream by default when table.read()
4 participants