Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-3512: Add filters pushdown for read datasource #3513

Merged
merged 5 commits into from
Dec 17, 2021

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented Dec 16, 2021

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

Add filters pushdown for read datasource

Changelog

  • Improvement
  • Performance Improvement

Related Issues

Fixes #3512

Test Plan

Unit Tests
Stateless Tests

@zhyass zhyass marked this pull request as draft December 16, 2021 17:20
@zhyass
Copy link
Member Author

zhyass commented Dec 16, 2021

Todo: fix unit tests

@zhyass zhyass changed the title ISSUE-3512: Add projection pushdown for read datasource ISSUE-3512: Add filters pushdown for read datasource Dec 16, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@zhyass zhyass marked this pull request as ready for review December 17, 2021 03:13
@zhyass zhyass requested a review from BohuTANG as a code owner December 17, 2021 03:13
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021

Codecov Report

Merging #3513 (f6e0425) into main (2ea8379) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3513   +/-   ##
=====================================
  Coverage     61%     61%           
=====================================
  Files        622     622           
  Lines      34816   34827   +11     
=====================================
+ Hits       21246   21257   +11     
  Misses     13570   13570           
Impacted Files Coverage Δ
common/functions/src/aggregates/aggregate_avg.rs 94% <ø> (ø)
common/planners/src/plan_display_indent.rs 97% <100%> (+<1%) ⬆️
...c/sql/statements/query/query_collect_push_downs.rs 93% <100%> (-2%) ⬇️
common/management/src/cluster/cluster_mgr.rs 81% <0%> (+<1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ea8379...f6e0425. Read the comment docs.

@BohuTANG BohuTANG merged commit 34dbe41 into databendlabs:main Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add filters pushdown for read datasource
6 participants