Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the context functions #3753

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Jan 4, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR:

Part of #3740 , only names changed.

  1. Simple get_user_manager()
  2. Rename get_data_accessor -> get_storage_accessor
  3. Rename get_table_cache -> get_storage_cache

Changelog

  • Improvement

Related Issues

Part of #3740

Test Plan

Unit Tests

Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Jan 4, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/FKCTBpWQze1SM3cP2FGkKQmAoa7d
✅ Preview: Canceled

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2022

Codecov Report

Merging #3753 (213916a) into main (a019084) will decrease coverage by 0%.
The diff coverage is 84%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3753   +/-   ##
=====================================
- Coverage     59%     59%   -1%     
=====================================
  Files        707     707           
  Lines      38206   38206           
=====================================
- Hits       22808   22785   -23     
- Misses     15398   15421   +23     
Impacted Files Coverage Δ
query/src/api/rpc/flight_service.rs 52% <0%> (ø)
...ery/src/interpreters/interpreter_describe_stage.rs 96% <ø> (ø)
query/src/interpreters/interpreter_kill.rs 0% <0%> (ø)
query/src/interpreters/interpreter_show_grants.rs 0% <ø> (ø)
...src/interpreters/plan_schedulers/plan_scheduler.rs 32% <0%> (ø)
.../src/pipelines/transforms/transform_create_sets.rs 0% <0%> (ø)
query/src/storages/system/processes_table.rs 25% <0%> (+<1%) ⬆️
query/src/sql/statements/analyzer_expr.rs 68% <50%> (ø)
query/src/storages/fuse/operations/optimize.rs 92% <85%> (+<1%) ⬆️
query/src/api/rpc/flight_dispatcher.rs 84% <100%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a019084...213916a. Read the comment docs.

@BohuTANG
Copy link
Member Author

BohuTANG commented Jan 4, 2022

Only function name changed, let's merge.

@BohuTANG BohuTANG merged commit 3a75eb5 into databendlabs:main Jan 4, 2022
@BohuTANG BohuTANG deleted the dev-context-refine branch January 4, 2022 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants