Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit parallelization when reading parquet columns. #4283

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Mar 1, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

fix #4253 (comment)

use tokio::sync::Semaphore to limit the number of parallel readers create from the reader factory.

Changelog

  • Not for changelog (changelog entry is not required)

Related Issues

Fixes #issue

Test Plan

Unit Tests

Stateless Tests

@vercel
Copy link

vercel bot commented Mar 1, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/4wd4i3DfbPB4y4D47zuB4HNvrQnh
✅ Preview: Canceled

@mergify
Copy link
Contributor

mergify bot commented Mar 1, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

Copy link
Member

@dantengsky dantengsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BohuTANG BohuTANG merged commit bc3b916 into databendlabs:main Mar 1, 2022
@youngsofun youngsofun deleted the parquet2 branch March 13, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optimize table ontime all returns Too many open files (os error 24)
4 participants