-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-4374: Simd selected for BooleanColumn #4484
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/databend/databend/F6N77mNbxgEW4g7ia7biy3yNeDGx [Deployment for 545fffb canceled] |
Thanks for the contribution! Please review the labels and make any necessary changes. |
.filter(|(_, b)| *b) | ||
.map(|(a, _)| a); | ||
let mut bitmap = MutableBitmap::with_capacity(selected); | ||
let mut chunks = self.values().chunks::<u64>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should follow the way of primitive::filter
.
Iterator of filter.values().chunks::<u64>
may cause too much u64 merges.
|
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Summary about this PR
Changelog
Related Issues
Fixes #4374
Test Plan
Unit Tests