Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use x.to_string() instead of format!("{}", x) #5359

Merged
merged 2 commits into from
May 13, 2022
Merged

chore: use x.to_string() instead of format!("{}", x) #5359

merged 2 commits into from
May 13, 2022

Conversation

andylokandy
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • code style refactoring

Changelog

  • Improvement

@andylokandy andylokandy requested a review from BohuTANG as a code owner May 13, 2022 11:58
@vercel
Copy link

vercel bot commented May 13, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview May 13, 2022 at 2:05PM (UTC)

@mergify
Copy link
Contributor

mergify bot commented May 13, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

BohuTANG
BohuTANG approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
BTW, how do you find them?

@andylokandy andylokandy changed the title chore: use x.string() instead of format!("{}", x) chore: use x.to_string() instead of format!("{}", x) May 13, 2022
@andylokandy
Copy link
Contributor Author

@BohuTANG I used regex replace for this PR. Anyway, @leiysky has proposed to make it as a lint

@BohuTANG BohuTANG merged commit b8e5194 into databendlabs:main May 13, 2022
@andylokandy andylokandy deleted the string branch May 13, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiysky leiysky leiysky approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

@BohuTANG BohuTANG BohuTANG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andylokandy @BohuTANG @Xuanwo @leiysky