Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(planner): support union/union all #7160

Merged
merged 15 commits into from
Aug 19, 2022
Merged

feat(planner): support union/union all #7160

merged 15 commits into from
Aug 19, 2022

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented Aug 17, 2022 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Support union distinct and union all

Fixes #7034

@vercel
Copy link

vercel bot commented Aug 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Aug 19, 2022 at 0:56AM (UTC)

@xudong963 xudong963 marked this pull request as draft August 17, 2022 12:08
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Aug 17, 2022
@xudong963 xudong963 requested review from leiysky and sundy-li August 18, 2022 06:09
@xudong963 xudong963 marked this pull request as ready for review August 18, 2022 06:10
@xudong963 xudong963 force-pushed the union branch 2 times, most recently from 82118b2 to 9c3e3aa Compare August 18, 2022 06:57
@xudong963
Copy link
Member Author

xudong963 commented Aug 18, 2022 •
edited
Loading

@zhang2014 I think your comments are similar to the change 31b090f ? Make receiver receive all messages

@zhang2014
Copy link
Member

@zhang2014 I think your comments are similar to the change 31b090f ? Make receiver receive all messages

We should not wait for all data to be ready before merge union left and right

@xudong963
Copy link
Member Author

We should not wait for all data to be ready before merge union left and right

I got you, thanks for your detailed explanation, learn much!

@mergify mergify bot merged commit 16a1226 into databendlabs:main Aug 19, 2022
@xudong963 xudong963 deleted the union branch August 19, 2022 01:23
@xudong963
Copy link
Member Author

@soyeric128 Please add union/union all to https://databend.rs/doc/reference/sql/query-operators/operators-set when you have time

@BohuTANG BohuTANG mentioned this pull request Aug 19, 2022
Closed
43 tasks
@soyeric128
Copy link
Collaborator

@soyeric128 Please add union/union all to https://databend.rs/doc/reference/sql/query-operators/operators-set when you have time

Ok

@soyeric128
Copy link
Collaborator

Please review #7281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiysky leiysky leiysky left review comments

@sundy-li sundy-li sundy-li approved these changes

@zhang2014 zhang2014 zhang2014 approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: support union/union all for databend
5 participants
@xudong963 @zhang2014 @soyeric128 @sundy-li @leiysky