Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): get the system open file limits and set #8388

Merged
merged 3 commits into from
Oct 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/binaries/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ databend-query = { path = "../query/service" }
# Crates.io dependencies
anyhow = { workspace = true }
clap = { workspace = true }
limits-rs = "0.1.0"
openraft = { workspace = true }
sentry = "0.27.0"
serde = { workspace = true }
Expand Down
24 changes: 24 additions & 0 deletions src/binaries/query/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ use databend_query::servers::MySQLHandler;
use databend_query::servers::Server;
use databend_query::servers::ShutdownHandle;
use databend_query::GlobalServices;
use limits_rs::get_own_limits;
Copy link
Member

@BohuTANG BohuTANG Oct 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the use.

use tracing::info;
use tracing::warn;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the use.


#[databend_main]
async fn main(_global_tracker: Arc<RuntimeTracker>) -> common_exception::Result<()> {
Expand Down Expand Up @@ -73,6 +75,9 @@ async fn main(_global_tracker: Arc<RuntimeTracker>) -> common_exception::Result<
init_default_metrics_recorder();
set_panic_hook();

#[cfg(not(target_os = "macos"))]
check_max_open_files();

GlobalServices::init(conf.clone()).await?;
let mut shutdown_handle = ShutdownHandle::create()?;

Expand Down Expand Up @@ -251,3 +256,22 @@ fn run_cmd(conf: &Config) -> bool {

true
}

#[cfg(not(target_os = "macos"))]
fn check_max_open_files() {
let limits = match get_own_limits() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_own_limits-->limits_rs::get_own_limits

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I need to file another PR to fix this problems?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

This works on my MacOS.

Ok(limits) => limits,
Err(err) => {
warn!("get system limit of databend-query failed: {:?}", err);
return;
}
};
let max_open_files_limit = limits.max_open_files.soft;
if let Some(max_open_files) = max_open_files_limit {
if max_open_files < 65535 {
warn!(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warn! --> tracing::warn!

"The open file limit is too low for the databend-query. Please consider increase it by running `ulimit -n 65535`"
);
}
}
}