-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query): improve sort. #8452
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RinChanNOWWW
force-pushed
the
improve_sort
branch
6 times, most recently
from
November 1, 2022 05:51
75359d2
to
51c6221
Compare
RinChanNOWWW
force-pushed
the
improve_sort
branch
from
November 1, 2022 06:03
51c6221
to
97701e8
Compare
Add fix logictest results in suites/crdb/order_by.
RinChanNOWWW
force-pushed
the
improve_sort
branch
from
November 2, 2022 12:05
ea7b5af
to
b6c9fd4
Compare
sundy-li
approved these changes
Nov 3, 2022
LGTM, but we need to improve to make some queries not slower than before in the next round. |
b41sh
reviewed
Nov 3, 2022
RinChanNOWWW
force-pushed
the
improve_sort
branch
from
November 3, 2022 02:47
e5328fc
to
2951f01
Compare
Conflicting files :) |
BohuTANG
approved these changes
Nov 4, 2022
The row format was merge into the main branch of arrow2. We can change the rev in Cargo.toml in later pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Perfomance test
Testing environment
query engine:
minio storge:
query engine machine and minio storage machine are connected via LAN.
Testing method:
Data is stored on another machine and fetched via minio. Every SQL is run 100 times.
Conclusion
New sort is 10%~50% faster than the old one.
Result
<style> td {white-space:pre-wrap;border:1px solid #dee0e3;}</style>top 100
<style> td {white-space:pre-wrap;border:1px solid #dee0e3;}</style>aggregation after sort
<style> td {white-space:pre-wrap;border:1px solid #dee0e3;}</style>