-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mysql): fix databend float64 to mysql double #8745
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
cc @sundy-li |
@mergify update |
☑️ Nothing to do
|
BTW, all of databend integers are converted to MYSQL_TYPE_LONG, is this the expected behavior? TypeID::Int8 => Ok(ColumnType::MYSQL_TYPE_LONG),
TypeID::Int16 => Ok(ColumnType::MYSQL_TYPE_LONG),
TypeID::Int32 => Ok(ColumnType::MYSQL_TYPE_LONG),
TypeID::Int64 => Ok(ColumnType::MYSQL_TYPE_LONG),
TypeID::UInt8 => Ok(ColumnType::MYSQL_TYPE_LONG),
TypeID::UInt16 => Ok(ColumnType::MYSQL_TYPE_LONG),
TypeID::UInt32 => Ok(ColumnType::MYSQL_TYPE_LONG),
TypeID::UInt64 => Ok(ColumnType::MYSQL_TYPE_LONG), |
I think it doesn't matter(no loss of precision). |
|
for me, I shoud pass databend data to hive, if I get query a small int column, databend produces long while hive expected small int, there maybe some problems. so I prefer to correct it like https://dev.mysql.com/doc/c-api/8.0/en/c-api-prepared-statement-type-codes.html. |
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Summary about this PR
Closes #issue