Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(planner): Improve join reorder algorithm #9571

Merged
merged 2 commits into from
Jan 12, 2023
Merged

chore(planner): Improve join reorder algorithm #9571

merged 2 commits into from
Jan 12, 2023

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Jan 11, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Introduce exchange rules to extend search space.

Also, introduce AppliedRules for Memo to reduce duplicated rule applications.

After this PR, the optimizer will generate bushy join trees.

@vercel
Copy link

vercel bot commented Jan 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jan 11, 2023 at 4:41PM (UTC)

@mergify

This comment was marked as off-topic.

Sign in to view
@leiysky leiysky changed the title improve(planner): Improve join reorder algorithm chore(planner): Improve join reorder algorithm Jan 11, 2023
@leiysky leiysky added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 11, 2023
@leiysky
Copy link
Contributor Author

leiysky commented Jan 11, 2023

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jan 11, 2023

update

✅ Branch has been successfully updated

@leiysky leiysky marked this pull request as draft January 11, 2023 10:10
@leiysky leiysky marked this pull request as ready for review January 11, 2023 11:54
@leiysky leiysky marked this pull request as draft January 11, 2023 11:59
@leiysky leiysky marked this pull request as ready for review January 11, 2023 15:53
@leiysky
Copy link
Contributor Author

leiysky commented Jan 11, 2023

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jan 11, 2023

update

✅ Branch has been successfully updated

@BohuTANG
Copy link
Member

test_sqllogic_base_cluster_linux and test_sqllogic_ydb_cluster_linux timeout after 30m.

@xudong963
Copy link
Member

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jan 12, 2023

update

☑️ Nothing to do

  • #commits-behind>0 [:pushpin: update requirement]
  • -closed [:pushpin: update requirement]

@xudong963
Copy link
Member

test_sqllogic_base_cluster_linux and test_sqllogic_ydb_cluster_linux timeout after 30m.

Seems related to #9558

@leiysky
Copy link
Contributor Author

leiysky commented Jan 12, 2023

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jan 12, 2023

update

☑️ Nothing to do

  • #commits-behind>0 [:pushpin: update requirement]
  • -closed [:pushpin: update requirement]

@leiysky
Copy link
Contributor Author

leiysky commented Jan 12, 2023

@mergify requeue

@mergify
Copy link
Contributor

mergify bot commented Jan 12, 2023

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@BohuTANG BohuTANG merged commit 356317f into databendlabs:main Jan 12, 2023
@leiysky leiysky deleted the join-order branch January 12, 2023 06:34
@xudong963 xudong963 mentioned this pull request Jan 14, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xudong963 xudong963 xudong963 approved these changes

@andylokandy andylokandy andylokandy approved these changes

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leiysky @BohuTANG @xudong963 @andylokandy