Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ParquetTable list file in read_partition. #9871

Merged
merged 4 commits into from
Feb 3, 2023

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Feb 3, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Closes #issue

part of #9847

@vercel
Copy link

vercel bot commented Feb 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Feb 3, 2023 at 3:04AM (UTC)

@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Feb 3, 2023
@sundy-li sundy-li requested a review from RinChanNOWWW February 3, 2023 02:01
Copy link
Contributor

@RinChanNOWWW RinChanNOWWW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some tests of selecting from stage with pattern.

@youngsofun
Copy link
Member Author

Need some tests of selecting from stage with pattern.

Is it ok to do it in the next pr?

  1. add parser
  2. add tests

@BohuTANG BohuTANG merged commit 0e9c807 into databendlabs:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants