-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate before committing and emit a log warning #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fqtab
commented
Mar 14, 2024
kafka-connect/src/main/java/io/tabular/iceberg/connect/channel/Coordinator.java
Outdated
Show resolved
Hide resolved
kafka-connect/src/main/java/io/tabular/iceberg/connect/channel/Coordinator.java
Outdated
Show resolved
Hide resolved
kafka-connect/src/main/java/io/tabular/iceberg/connect/channel/Coordinator.java
Outdated
Show resolved
Hide resolved
18002f2
to
0eb22c2
Compare
193b1c5
to
0257c6c
Compare
fqtab
commented
Mar 14, 2024
kafka-connect/src/main/java/io/tabular/iceberg/connect/channel/Coordinator.java
Outdated
Show resolved
Hide resolved
kafka-connect/src/main/java/io/tabular/iceberg/connect/channel/Coordinator.java
Outdated
Show resolved
Hide resolved
kafka-connect/src/main/java/io/tabular/iceberg/connect/channel/Coordinator.java
Outdated
Show resolved
Hide resolved
kafka-connect/src/main/java/io/tabular/iceberg/connect/channel/Coordinator.java
Outdated
Show resolved
Hide resolved
fqtab
commented
Mar 14, 2024
kafka-connect/src/main/java/io/tabular/iceberg/connect/channel/Deduplicated.java
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
approved these changes
Mar 14, 2024
a33da6d
to
39eaa8d
Compare
kafka-connect/src/main/java/io/tabular/iceberg/connect/channel/Deduplicated.java
Show resolved
Hide resolved
kafka-connect/src/main/java/io/tabular/iceberg/connect/channel/Deduplicated.java
Outdated
Show resolved
Hide resolved
kafka-connect/src/main/java/io/tabular/iceberg/connect/channel/Deduplicated.java
Outdated
Show resolved
Hide resolved
tabmatfournier
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verbose due to the logging cases which we may be able to clean up in a later PR once this has been out for a time.
Minor comments only, I think you can use Pair
from iceberg utils.
6d1a1e7
to
09e1e94
Compare
2e0b959
to
7e1266d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
How?
In this case, you should see a log message similar to
Deduplicated 2 data files with the same path=data.parquet for table=db.tbl during commit-id=cf602430-0f4d-41d8-a3e9-171848d89832 from the following events=[2x(SimpleEnvelope{...})]
In this case, you should see a log message similar to
Deduplicated 2 data files with the same path=data.parquet for table=db.tbl during commit-id=cf602430-0f4d-41d8-a3e9-171848d89832 from the following events=[1x(SimpleEnvelope{...}), 1x(SimpleEnvelope{...})]
Deduplicated 2 data files with the same path=data.parquet in the same event=SimpleEnvelope{...} for table=db.tbl during commit-id=cf602430-0f4d-41d8-a3e9-171848d89832