move-noisy-debug-logs-to-debug #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- these logs are the equivilent of "HERE" and account for ~75% of the logs but are generally not useful. Moving them to debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These logs are the equivalent of "HERE" and account for ~75% of the logs but are generally not useful and drive up logging costs for anyone using this in production. Moved them to debug level if someone needs to debug something going on in an error scenario, but generally these logs have no context and are not useful.
Unfortunately, users can't blacklist worker/channel/coordinator in their log platform of choice as there are useful log messages around table commits succeeding. No metrics are available yet that can replace successful commits.
Moved them to debug level in the off chance someone is using them. Could be convinced to delete them entirely.