don't let ids start with a number (#161)

Fixes #159 Co-authored-by: Li Haoyi <[email protected]>
databricks · May 30, 2023 · f4bed42 · f4bed42
1 parent 1b4a5c0
commit f4bed42
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/sjsonnet/src/sjsonnet/Parser.scala b/sjsonnet/src/sjsonnet/Parser.scala
@@ -54,7 +54,7 @@ class Parser(val currentFile: Path) {
   def Pos[_: P]: P[Position] = Index.map(offset => new Position(fileScope, offset))
 
   def id[_: P] = P(
-    CharIn("_a-zA-Z0-9") ~~
+    CharIn("_a-zA-Z") ~~
     CharsWhileIn("_a-zA-Z0-9", 0)
   ).!.filter(s => !keywords.contains(s))
 

diff --git a/sjsonnet/test/src/sjsonnet/ParserTests.scala b/sjsonnet/test/src/sjsonnet/ParserTests.scala
@@ -27,5 +27,8 @@ object ParserTests extends TestSuite{
     test("givenDuplicateFieldsInListComprehension_expectError") {
       parseErr("""{ ["bar"]: x for x in [1, 2]}""") ==> """Expected no duplicate field: "bar" :1:29, found "}""""
     }
+    test("id starts with number") {
+      parseErr("""{1_n: "foo",}""") ==> """Expected "}":1:2, found "1_n: \"foo\"""""
+    }
   }
 }