feat: barebones sub-query support #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing as I overlooked the rewriting of subqueries to joins. |
phillipleblanc
pushed a commit
that referenced
this pull request
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #33. cc @sardination
The PR includes barebones (see below) support for subqueries. I also tried to re-write the analyzer logic in an attempt to make it more readable.
While creating the example I realized that the current approach obviously doesn't support usage of an outer reference. (yes, making this implementation rather useless). Next steps on that topic could be:
I suggest the first point is looked into in a new PR. It's also becoming clear we'll need to look into a good way to get tests setup. For example by federating to DataFusion itself.