Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade datafusion & arrow #57

Closed
wants to merge 3 commits into from
Closed

upgrade datafusion & arrow #57

wants to merge 3 commits into from

Conversation

xhwhis
Copy link
Contributor

@xhwhis xhwhis commented Sep 18, 2024

upgrade datafusion to 42 and arrow to 53.
the .taplo.toml file is copied from dadafusion.
BTW, I think we don't need datafusion and arrow dependencies, just need subcrates like dadafusion-expr and arrow-array. If you agree, I would do this.

@backkem backkem requested a review from hozan23 September 18, 2024 08:19
Copy link
Collaborator

@hozan23 hozan23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xhwhis.

@hozan23
Copy link
Collaborator

hozan23 commented Sep 18, 2024

BTW, I think we don't need datafusion and arrow dependencies, just need subcrates like dadafusion-expr and arrow-array. If you agree, I would do this.

@xhwhis Indeed, that would be useful to minimize the number of dependencies and reduce compile time. You can go ahead with this.

Thanks

@xhwhis
Copy link
Contributor Author

xhwhis commented Sep 18, 2024

@xhwhis Indeed, that would be useful to minimize the number of dependencies and reduce compile time. You can go ahead with this.

@hozan23 done

@hozan23
Copy link
Collaborator

hozan23 commented Sep 18, 2024

Hey @xhwhis

I am sorry but I believe this is not the ideal way to manage dependencies in rust. I thought you intended to use Cargo features to minimize the dependencies. Your current approach, where you're importing the subcrates, won't make a difference since you're also importing the main crate datafusion, It will also make it much harder to manage dependencies. It's best to reduce dependencies using Cargo features for the main crate. You can find the available features for datafusion here, which allows you to include only the necessary features (crates) for each crate in our repository.

@xhwhis
Copy link
Contributor Author

xhwhis commented Sep 19, 2024

merge PR #59, close it.

@xhwhis xhwhis closed this Sep 19, 2024
@xhwhis xhwhis deleted the upgrade-deps branch September 19, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants