fix: urlencode slash in urns too

Urns for datasources with datasetNameDelimiter: "/" was not encoded
correctly, resulting in REST calls not returning any data when querying
with the urn.

metadata-ingestion/src/datahub/cli/cli_utils.py

@@ -448,7 +448,7 @@ def batch_get_ids(
     url = gms_host + endpoint
     ids_to_get = []
     for id in ids:
-        ids_to_get.append(urllib.parse.quote(id))
+        ids_to_get.append(urllib.parse.quote(id, safe=""))
 
     response = session.get(
         f"{url}?ids=List({','.join(ids_to_get)})",
@@ -515,7 +515,7 @@ def get_entity(
         # we assume the urn is already encoded
         encoded_urn: str = urn
     elif urn.startswith("urn:"):
-        encoded_urn = urllib.parse.quote(urn)
+        encoded_urn = urllib.parse.quote(urn, safe="")
     else:
         raise Exception(
             f"urn {urn} does not seem to be a valid raw (starts with urn:) or encoded urn (starts with urn%3A)"

metadata-ingestion/src/datahub/cli/timeline_cli.py

@@ -74,7 +74,7 @@ def get_timeline(
         # we assume the urn is already encoded
         encoded_urn: str = urn
     elif urn.startswith("urn:"):
-        encoded_urn = urllib.parse.quote(urn)
+        encoded_urn = urllib.parse.quote(urn, safe="")
     else:
         raise Exception(
             f"urn {urn} does not seem to be a valid raw (starts with urn:) or encoded urn (starts with urn%3A)"

metadata-ingestion/src/datahub/ingestion/graph/client.py

@@ -126,7 +126,7 @@ def get_aspect_v2(
         :rtype: Optional[Aspect]
         :raises HttpError: if the HTTP response is not a 200 or a 404
         """
-        url = f"{self._gms_server}/aspects/{urllib.parse.quote(entity_urn)}?aspect={aspect}&version=0"
+        url = f"""{self._gms_server}/aspects/{urllib.parse.quote(entity_urn, safe="")}?aspect={aspect}&version=0"""
         response = self._session.get(url)
         if response.status_code == 404:
             # not found