fix(shadowJar): fix shadowJar (#11968)

datahub-project · Nov 27, 2024 · 3b00fd7 · 3b00fd7
1 parent f9cc67d
commit 3b00fd7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/.github/workflows/check-datahub-jars.yml b/.github/workflows/check-datahub-jars.yml
@@ -40,4 +40,5 @@ jobs:
       - name: check ${{ matrix.command }} jar
         run: |
           ./gradlew :metadata-integration:java:${{ matrix.command }}:build --info
+          ./gradlew :metadata-integration:java:${{ matrix.command }}:checkShadowJar
           ./gradlew :metadata-integration:java:${{ matrix.command }}:javadoc
diff --git a/metadata-integration/java/datahub-protobuf/scripts/check_jar.sh b/metadata-integration/java/datahub-protobuf/scripts/check_jar.sh
@@ -44,7 +44,9 @@ jar -tvf $jarFile |\
       grep -v "mime.types" |\
       grep -v "com/ibm/.*" |\
       grep -v "org/glassfish/" |\
-      grep -v "LICENSE"
+      grep -v "LICENSE" |\
+      grep -v "org/apache/avro" |\
+      grep -v "org/apache"
 
 if [ $? -ne 0 ]; then
   echo "✅ No unexpected class paths found in ${jarFile}"

diff --git a/metadata-integration/java/datahub-schematron/lib/build.gradle b/metadata-integration/java/datahub-schematron/lib/build.gradle
@@ -45,10 +45,6 @@ jacocoTestReport {
 
 test.finalizedBy jacocoTestReport
 
-task checkShadowJar(type: Exec) {
-   commandLine 'sh', '-c', 'scripts/check_jar.sh'
-}
-
 configurations {
     provided
     implementation.extendsFrom provided