Skip to content

Commit

Permalink
fix(ingest): avoid bad IPython version (#12035)
Browse files Browse the repository at this point in the history
  • Loading branch information
hsheth2 authored Dec 4, 2024
1 parent 97e3282 commit 65f44ef
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions metadata-ingestion/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,15 @@
# datahub does not depend on traitlets directly but great expectations does.
# https://github.com/ipython/traitlets/issues/741
"traitlets!=5.2.2",
# GE depends on IPython - we have no direct dependency on it.
# IPython 8.22.0 added a dependency on traitlets 5.13.x, but only declared a
# version requirement of traitlets>5.
# See https://github.com/ipython/ipython/issues/14352.
# This issue was fixed by https://github.com/ipython/ipython/pull/14353,
# which first appeared in IPython 8.22.1.
# As such, we just need to avoid that version in order to get the
# dependencies that we need. IPython probably should've yanked 8.22.0.
"IPython!=8.22.0",
"greenlet",
*cachetools_lib,
}
Expand Down

0 comments on commit 65f44ef

Please sign in to comment.