Skip to content

Commit

Permalink
address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
sid-acryl committed Jul 1, 2024
1 parent 094ad86 commit 954e544
Showing 1 changed file with 4 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -564,15 +564,10 @@ def _get_tag_mce_for_urn(tag_urn: str) -> MetadataChangeEvent:
def _get_tags_from_field_type(
field: ViewField, reporter: SourceReport
) -> Optional[GlobalTagsClass]:
schema_field_tags: List[TagAssociationClass] = []

# Add any user defined tag present on field
schema_field_tags.extend(
[
TagAssociationClass(tag=builder.make_tag_urn(tag_name))
for tag_name in field.tags
]
)
schema_field_tags: List[TagAssociationClass] = [
TagAssociationClass(tag=builder.make_tag_urn(tag_name))
for tag_name in field.tags
]

if field.field_type in LookerUtil.type_to_tag_map:
schema_field_tags.extend(
Expand Down

0 comments on commit 954e544

Please sign in to comment.