feat(analytics): Add page number to SearchResultClickEvent analytics …

…event (#11151)
datahub-project · Aug 20, 2024 · f15a7fe · f15a7fe
1 parent 8f7642b
commit f15a7fe
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 1 deletion.
diff --git a/datahub-web-react/src/app/analytics/event.ts b/datahub-web-react/src/app/analytics/event.ts
@@ -191,6 +191,7 @@ export interface SearchResultClickEvent extends BaseEvent {
     entityTypeFilter?: EntityType;
     index: number;
     total: number;
+    pageNumber: number;
 }
 
 export interface SearchFiltersClearAllEvent extends BaseEvent {

diff --git a/datahub-web-react/src/app/search/SearchResultList.tsx b/datahub-web-react/src/app/search/SearchResultList.tsx
@@ -62,6 +62,7 @@ type Props = {
     selectedEntities: EntityAndType[];
     setSelectedEntities: (entities: EntityAndType[]) => any;
     suggestions: SearchSuggestion[];
+    pageNumber: number;
 };
 
 export const SearchResultList = ({
@@ -73,6 +74,7 @@ export const SearchResultList = ({
     selectedEntities,
     setSelectedEntities,
     suggestions,
+    pageNumber,
 }: Props) => {
     const entityRegistry = useEntityRegistry();
     const selectedEntityUrns = selectedEntities.map((entity) => entity.urn);
@@ -86,6 +88,7 @@ export const SearchResultList = ({
             entityType: result.entity.type,
             index,
             total: totalResultCount,
+            pageNumber,
         });
     };
 

diff --git a/datahub-web-react/src/app/search/SearchResults.tsx b/datahub-web-react/src/app/search/SearchResults.tsx
@@ -264,6 +264,7 @@ export const SearchResults = ({
                                         selectedEntities={selectedEntities}
                                         setSelectedEntities={setSelectedEntities}
                                         suggestions={suggestions}
+                                        pageNumber={page}
                                     />
                                     {totalResults > 0 && (
                                         <PaginationControlContainer id="search-pagination">

diff --git a/docs/developers.md b/docs/developers.md
@@ -46,7 +46,7 @@ Use [gradle wrapper](https://docs.gradle.org/current/userguide/gradle_wrapper.ht
 ./gradlew build
 ```
 
-Note that the above will also run run tests and a number of validations which makes the process considerably slower.
+Note that the above will also run tests and a number of validations which makes the process considerably slower.
 
 We suggest partially compiling DataHub according to your needs: