move to env variables

datahub-project · May 10, 2022 · f69e096 · f69e096
1 parent 39677f1
commit f69e096
Showing 1 changed file with 42 additions and 30 deletions.
diff --git a/.github/workflows/docker-unified.yml b/.github/workflows/docker-unified.yml
@@ -15,6 +15,17 @@ on:
   release:
     types: [published, edited]
 
+env:
+  DATAHUB_GMS_IMAGE: 'linkedin/datahub-gms'
+  DATAHUB_FRONTEND_IMAGE: 'linkedin/datahub-frontend-react'
+  DATAHUB_MAE_CONSUMER_IMAGE: 'linkedin/datahub-mae-consumer'
+  DATAHUB_MCE_CONSUMER_IMAGE: 'linkedin/datahub-mce-consumer'
+  DATAHUB_KAFKA_SETUP_IMAGE: 'linkedin/datahub-kafka-setup'
+  DATAHUB_ELASTIC_SETUP_IMAGE: 'linkedin/datahub-elasticsearch-setup'
+  DATAHUB_MYSQL_SETUP_IMAGE: 'acryldata/datahub-mysql-setup'
+  DATAHUB_UPGRADE_IMAGE: 'linkedin/datahub-upgrade'
+
+
 jobs:
   setup:
     runs-on: ubuntu-latest
@@ -49,7 +60,7 @@ jobs:
     needs: setup
     outputs:
       image_tag: ${{ steps.docker_meta.outputs.tags }}
-      image_name: 'linkedin/datahub-gms'
+      image_name: ${{ env.DATAHUB_GMS_IMAGE }}
     steps:
       - name: Check out the repo
         uses: actions/checkout@v2
@@ -61,7 +72,7 @@ jobs:
         with:
           # list of Docker images to use as base name for tags
           images: |
-            linkedin/datahub-gms
+            ${{ env.DATAHUB_GMS_IMAGE }}
           # add git short SHA as Docker tag
           tag-custom: ${{ needs.setup.outputs.tag }}
           tag-custom-only: true
@@ -109,11 +120,11 @@ jobs:
         if: ${{ needs.setup.outputs.publish != 'true' }}
         uses: ishworkh/docker-image-artifact-download@v1
         with:
-          image: ${{ needs.gms_build.outputs.image_name }}:${{ needs.setup.outputs.unique_tag }}
+          image: ${{ env.DATAHUB_GMS_IMAGE }}:${{ needs.setup.outputs.unique_tag }}
       - name: Run Trivy vulnerability scanner
         uses: aquasecurity/trivy-action@master
         with:
-          image-ref: ${{ needs.gms_build.outputs.image_name }}:${{ needs.setup.outputs.unique_tag }}
+          image-ref: ${{ env.DATAHUB_GMS_IMAGE }}:${{ needs.setup.outputs.unique_tag }}
           format: 'table'
           ignore-unfixed: true
           vuln-type: 'os,library'
@@ -124,6 +135,7 @@ jobs:
     needs: setup
     outputs:
       image_tag: ${{ steps.docker_meta.outputs.tags }}
+      image_name: ${{ env.DATAHUB_MAE_CONSUMER }}
     steps:
       - name: Check out the repo
         uses: actions/checkout@v2
@@ -135,7 +147,7 @@ jobs:
         with:
           # list of Docker images to use as base name for tags
           images: |
-            linkedin/datahub-mae-consumer
+            ${{ env.DATAHUB_MAE_CONSUMER }}
           # add git short SHA as Docker tag
           tag-custom: ${{ needs.setup.outputs.tag }}
           tag-custom-only: true
@@ -162,17 +174,17 @@ jobs:
   mae_consumer_scan:
     name: "[Monitoring] Scan MAE consumer images for vulnerabilities"
     runs-on: ubuntu-latest
-    needs: mae_consumer_build
+    needs: [setup,mae_consumer_build]
     steps:
       - name: Download image
         if: ${{ needs.setup.outputs.publish != 'true' }}
         uses: ishworkh/docker-image-artifact-download@v1
         with:
-          image: ${{ needs.mae_consumer_build.outputs.image_tag }}
+          image: ${{ env.DATAHUB_MAE_CONSUMER_IMAGE }}:${{ needs.setup.outputs.unique_tag }}
       - name: Run Trivy vulnerability scanner
         uses: aquasecurity/trivy-action@master
         with:
-          image-ref: ${{ needs.mae_consumer_build.outputs.image_tag }}
+          image-ref: ${{ env.DATAHUB_MAE_CONSUMER_IMAGE }}:${{ needs.setup.outputs.unique_tag }}
           format: 'table'
           ignore-unfixed: true
           vuln-type: 'os,library'
@@ -194,7 +206,7 @@ jobs:
         with:
           # list of Docker images to use as base name for tags
           images: |
-            linkedin/datahub-mce-consumer
+            ${{ env.DATAHUB_MCE_CONSUMER_IMAGE }}
           # add git short SHA as Docker tag
           tag-custom: ${{ needs.setup.outputs.tag }}
           tag-custom-only: true
@@ -221,17 +233,17 @@ jobs:
   mce_consumer_scan:
     name: "[Monitoring] Scan MCE consumer images for vulnerabilities"
     runs-on: ubuntu-latest
-    needs: mce_consumer_build
+    needs: [setup, mce_consumer_build]
     steps:
       - name: Download image
         if: ${{ needs.setup.outputs.publish != 'true' }}
         uses: ishworkh/docker-image-artifact-download@v1
         with:
-          image: ${{ needs.mce_consumer_build.outputs.image_tag }}
+          image: ${{ env.DATAHUB_MCE_CONSUMER_IMAGE }}:${{ needs.setup.outputs.unique_tag }}
       - name: Run Trivy vulnerability scanner
         uses: aquasecurity/trivy-action@master
         with:
-          image-ref: ${{ needs.mce_consumer_build.outputs.image_tag }}
+          image-ref: ${{ env.DATAHUB_MCE_CONSUMER_IMAGE }}:${{ needs.setup.outputs.unique_tag }}
           format: 'table'
           ignore-unfixed: true
           vuln-type: 'os,library'
@@ -253,7 +265,7 @@ jobs:
         with:
           # list of Docker images to use as base name for tags
           images: |
-            linkedin/datahub-upgrade
+            ${{ env.DATAHUB_UPGRADE_IMAGE }}
           # add git short SHA as Docker tag
           tag-custom: ${{ needs.setup.outputs.tag }}
           tag-custom-only: true
@@ -280,17 +292,17 @@ jobs:
   datahub_upgrade_scan:
     name: "[Monitoring] Scan DataHub Upgrade images for vulnerabilities"
     runs-on: ubuntu-latest
-    needs: datahub_upgrade_build
+    needs: [setup, datahub_upgrade_build]
     steps:
       - name: Download image
         if: ${{ needs.setup.outputs.publish != 'true' }}
         uses: ishworkh/docker-image-artifact-download@v1
         with:
-          image: ${{ needs.datahub_upgrade_build.outputs.image_tag }}
+          image: ${{ env.DATAHUB_UPGRADE_IMAGE }}:${{ needs.setup.outputs.unique_tag }}
       - name: Run Trivy vulnerability scanner
         uses: aquasecurity/trivy-action@master
         with:
-          image-ref: ${{ needs.datahub_upgrade_build.outputs.image_tag }}
+          image-ref: ${{ env.DATAHUB_UPGRADE_IMAGE }}:${{ needs.setup.outputs.unique_tag }}
           format: 'table'
           ignore-unfixed: true
           vuln-type: 'os,library'
@@ -312,7 +324,7 @@ jobs:
         with:
           # list of Docker images to use as base name for tags
           images: |
-            linkedin/datahub-frontend-react
+            ${{ env.DATAHUB_FRONTEND_IMAGE }}
           # add git short SHA as Docker tag
           tag-custom: ${{ needs.setup.outputs.tag }}
           tag-custom-only: true
@@ -354,17 +366,17 @@ jobs:
   frontend_scan:
     name: "[Monitoring] Scan Frontend images for vulnerabilities"
     runs-on: ubuntu-latest
-    needs: frontend_build
+    needs: [setup,frontend_build]
     steps:
       - name: Download image
         if: ${{ needs.setup.outputs.publish != 'true' }}
         uses: ishworkh/docker-image-artifact-download@v1
         with:
-          image: ${{ needs.frontend_build.outputs.image_tag }}
+          image: ${{ env.DATAHUB_FRONTEND_IMAGE }}:${{ needs.setup.outputs.unique_tag }}
       - name: Run Trivy vulnerability scanner
         uses: aquasecurity/trivy-action@master
         with:
-          image-ref: ${{ needs.frontend_build.outputs.image_tag }}
+          image-ref: ${{ env.DATAHUB_FRONTEND_IMAGE }}:${{ needs.setup.outputs.unique_tag }}
           format: 'table'
           ignore-unfixed: true
           vuln-type: 'os,library'
@@ -441,7 +453,7 @@ jobs:
         with:
           # list of Docker images to use as base name for tags
           images: |
-            acryldata/datahub-mysql-setup
+            ${{ env.DATAHUB_MYSQL_SETUP_IMAGE }}
           # add git short SHA as Docker tag
           tag-custom: ${{ needs.setup.outputs.tag }}
           tag-custom-only: true
@@ -483,7 +495,7 @@ jobs:
         with:
           # list of Docker images to use as base name for tags
           images: |
-            linkedin/datahub-elasticsearch-setup
+            ${{ env.DATAHUB_ELASTIC_SETUP_IMAGE }}
           # add git short SHA as Docker tag
           tag-custom: ${{ needs.setup.outputs.tag }}
           tag-custom-only: true
@@ -544,34 +556,34 @@ jobs:
         if: ${{ needs.setup.outputs.publish != 'true' }}
         uses: ishworkh/docker-image-artifact-download@v1
         with:
-          image: ${{ needs.gms_build.outputs.image_tag }}
+          image: ${{ env.DATAHUB_GMS_IMAGE }}:${{ needs.setup.outputs.unique_tag }}
       - name: Download Frontend image
         if: ${{ needs.setup.outputs.publish != 'true' }}
         uses: ishworkh/docker-image-artifact-download@v1
         with:
-          image: ${{ needs.frontend_build.outputs.image_tag }}
+          image:  ${{ env.DATAHUB_FRONTEND_IMAGE }}:${{ needs.setup.outputs.unique_tag }}
       - name: Download Kafka Setup image
         if: ${{ needs.setup.outputs.publish != 'true' }}
         uses: ishworkh/docker-image-artifact-download@v1
         with:
-          image: ${{ needs.kafka_setup_build.outputs.image_tag }}
+          image: ${{ env.DATAHUB_KAFKA_SETUP_IMAGE }}:${{ needs.setup.outputs.unique_tag }}
       - name: Download Mysql Setup image
         if: ${{ needs.setup.outputs.publish != 'true' }}
         uses: ishworkh/docker-image-artifact-download@v1
         with:
-          image: ${{ needs.mysql_setup_build.outputs.image_tag }}
+          image: ${{ env.DATAHUB_MYSQL_SETUP_IMAGE }}:${{ needs.setup.outputs.unique_tag }}
       - name: Download Elastic Setup image
         if: ${{ needs.setup.outputs.publish != 'true' }}
         uses: ishworkh/docker-image-artifact-download@v1
         with:
-          image: ${{ needs.elastic_setup_build.outputs.image_tag }}
+          image: ${{ env.DATAHUB_ELASTIC_SETUP_IMAGE }}:${{ needs.setup.outputs.unique_tag }}
       - name: Smoke test
+        env:
+          DATAHUB_VERSION: ${{ needs.setup.outputs.unique_tag }}
+          CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
         run: |
           echo "$DATAHUB_VERSION"
           ./smoke-test/smoke.sh
-        env:
-          DATAHUB_VERSION: ${{ needs.setup.outputs.tag }}
-          CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
       - uses: actions/upload-artifact@v2
         if: always()
         with: