Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI support for customProperties in DatasetProperties aspect #1730

Closed
jsotelo opened this issue Jul 13, 2020 · 5 comments · Fixed by #1905
Closed

UI support for customProperties in DatasetProperties aspect #1730

jsotelo opened this issue Jul 13, 2020 · 5 comments · Fixed by #1905
Assignees
Labels
accepted An Issue that is confirmed as a bug by the DataHub Maintainers. feature-request Request for a new feature to be added

Comments

@jsotelo
Copy link
Contributor

jsotelo commented Jul 13, 2020

Is your feature request related to a problem? Please describe.
The aspect com.linkedin.pegasus2avro.dataset.DatasetProperties has a field customProperties that is valuable in representing data properties that don't quite fit in any other (current) data model which is very valuable. However, the UI doesn't currently display any custom properties.

Describe the solution you'd like
Please add a UI representation (tab?) to convey all custom properties in that aspect. Perhaps similar to the Schema tab?

Describe alternatives you've considered
No other alternatives have been considered

Additional context
For the DataHub users/devs that are not able to afford forking the repo and creating their own data models, having basic support (UI display) for non-off-the-shelf data assets is extremely valuable because it can be used as a stop-gap while developing more explicit data models (or waiting for "official" DataHub models to be released).

As DataHub begins to have a greater presence and influence in users'/devs' tech stack, more prioritization and resources can be allocated into developing code (or making open-source contributions) that enables them to move data out of customProperties and into a more explicit data model.

@jsotelo jsotelo added the feature-request Request for a new feature to be added label Jul 13, 2020
@jsotelo
Copy link
Contributor Author

jsotelo commented Jul 13, 2020

@jsotelo jsotelo changed the title UI support for custumProperties in DatasetProperties aspect UI support for customProperties in DatasetProperties aspect Jul 13, 2020
@cobolbaby
Copy link
Contributor

cobolbaby commented Jul 15, 2020

Is this feature helpful for the display of tags information?

@jsotelo
Copy link
Contributor Author

jsotelo commented Jul 15, 2020

I was focused more on customProperties but it totally makes sense to also include tags as part of this, IMO.

@pmsrao
Copy link
Contributor

pmsrao commented Jul 23, 2020

may be we can look at two steps

  • display attributes in UI customerProperties & tags and

  • making it available for search
    this issue can focus on the first aspect

@mars-lan mars-lan added the accepted An Issue that is confirmed as a bug by the DataHub Maintainers. label Jul 30, 2020
@cobolbaby
Copy link
Contributor

cobolbaby commented Sep 3, 2020

I really want to know the progress of this work, and I look forward to setting some tags on the dataset on the page.

Due to some practical factors, some descriptive meta-information cannot be collected at present, and it can only be configured through the post page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted An Issue that is confirmed as a bug by the DataHub Maintainers. feature-request Request for a new feature to be added
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants