Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Adds ability for midtier to serve custom dataset properties from aspect #1881

Merged
merged 1 commit into from
Sep 20, 2020

Conversation

cptran777
Copy link
Contributor

Summary

This PR adds the ability for the midtier to serve custom dataset properties from the aspect com.linkedin.dataset.DatasetProperties. This is the first step in allowing the frontend to show custom properties. We modifier the DatasetView object to have a spot for customProperties and modify the client serving this to add information from the custom properties to the view. Upon a GET request to the midtier, this will include those custom properties in the response. We also add some tags and custom properties to create a sample aspect in our sample ingestion file to provide a way to better experience this with some mock data.

Issues Addressed

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Copy link
Contributor

@mars-lan mars-lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@cptran777 cptran777 merged commit 57fdc5c into master Sep 20, 2020
@cptran777 cptran777 deleted the custom-dataset-properties branch September 20, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants