Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom properties to Dashboards #2439

Closed
thomasplarsson opened this issue Apr 22, 2021 · 6 comments
Closed

Add custom properties to Dashboards #2439

thomasplarsson opened this issue Apr 22, 2021 · 6 comments
Labels
feature-request Request for a new feature to be added

Comments

@thomasplarsson
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Dashboard sources such as Qliksense applications often come with a set of key-value properties on them which would be nice to have in DataHub. This seems missing at the moment.

Describe the solution you'd like
Support for custom properties, similar to how it exists for Datasets already.

Describe alternatives you've considered
Haven't really seen any alternatives.

Additional context
Add any other context or screenshots about the feature request here.
@thomasplarsson thomasplarsson added the feature-request Request for a new feature to be added label Apr 22, 2021
@thomasplarsson
Copy link
Contributor Author

Fixed in 851e00b

@thomasplarsson
Copy link
Contributor Author

Re-opening since the UI is still lacking support for this feature.

@shirshanka
Copy link
Contributor

@topwebtek7 you might want to pick this one up.

@topwebtek7
Copy link
Contributor

@shirshanka sure!

@RickardCardell
Copy link
Contributor

@topwebtek7 @shirshanka I got some code ready for a PR

shirshanka pushed a commit that referenced this issue Apr 27, 2021
feat(react): add custom properties tab on dashboard profile page (#2439…
48ea19a 
…) (#2469)
@thomasplarsson
Copy link
Contributor Author

Fixed in #2469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request Request for a new feature to be added
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@RickardCardell @shirshanka @thomasplarsson @topwebtek7