fix(ui/user-group): add non existent entity page for user #10004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshbansal
reviewed
Mar 21, 2024
| @@ -240,4 +240,9 @@ public boolean doesPasswordMatch(@Nonnull String userUrnString, @Nonnull String | |||
| String hashedPassword = _secretService.getHashedPassword(salt, password); | |||
| return storedHashedPassword.equals(hashedPassword); | |||
| } | |||
|
|
|||
| public boolean userExists(@Nonnull Urn userUrn) { | |||
| Objects.requireNonNull(userUrn, "groupUrn must not be null"); | |||
There was a problem hiding this comment.
This should be userUrn
anshbansal
reviewed
Mar 21, 2024
Comment on lines
40
to
46
| final Urn urn = Urn.createFromString(userUrnString); | ||
| if (!_nativeUserService.userExists(urn)) { | ||
| // The group doesn't exist. | ||
| throw new DataHubGraphQLException( | ||
| String.format("Failed to add members to group %s. Group does not exist.", urn), | ||
| DataHubGraphQLErrorCode.NOT_FOUND); | ||
| } |
There was a problem hiding this comment.
How is CreateNativeUserResetTokenResolver related to user exists check?
anshbansal
approved these changes
Mar 22, 2024
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Jun 25, 2024
…oject#10004) Co-authored-by: akarsh991 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist