Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add doc for assertions & data contracts #10029

Merged
merged 7 commits into from
Mar 22, 2024
Merged

docs: add doc for assertions & data contracts #10029

merged 7 commits into from
Mar 22, 2024

Conversation

yoonhyejin
Copy link
Collaborator

@yoonhyejin yoonhyejin commented Mar 12, 2024 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

datahub-project/static-assets#75 this should be merged first.

@github-actions github-actions bot added the docs Issues and Improvements to docs label Mar 12, 2024
@yoonhyejin yoonhyejin requested a review from hsheth2 March 14, 2024 07:05
@yoonhyejin yoonhyejin marked this pull request as ready for review March 14, 2024 07:06
@yoonhyejin yoonhyejin changed the title feat: init draft for obs doc docs: add doc for assertions & data contracts Mar 14, 2024
hsheth2
hsheth2 reviewed Mar 15, 2024
View reviewed changes
docs/managed-datahub/observe/assertions.md Outdated Show resolved Hide resolved
docs/managed-datahub/observe/assertions.md Outdated Show resolved Hide resolved
docs/managed-datahub/observe/assertions.md Outdated Show resolved Hide resolved
docs/managed-datahub/observe/assertions.md Outdated Show resolved Hide resolved
docs/managed-datahub/observe/data-contract.md Outdated Show resolved Hide resolved
docs/managed-datahub/observe/data-contract.md Outdated Show resolved Hide resolved
docs/managed-datahub/observe/data-contract.md Outdated Show resolved Hide resolved
docs/managed-datahub/observe/data-contract.md Outdated Show resolved Hide resolved
docs/managed-datahub/observe/data-contract.md Outdated Show resolved Hide resolved
@yoonhyejin yoonhyejin requested a review from hsheth2 March 15, 2024 06:50
@yoonhyejin yoonhyejin enabled auto-merge (squash) March 21, 2024 15:39
hsheth2
hsheth2 approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

fyi @jjoyce0510

@yoonhyejin yoonhyejin merged commit 1cff5ef into master Mar 22, 2024
53 checks passed
@yoonhyejin yoonhyejin deleted the docs/obs-doc branch March 22, 2024 01:24
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@yoonhyejin @sleeperdeep
docs: add doc for assertions & data contracts (datahub-project#10029)
676f3c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
docs Issues and Improvements to docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoonhyejin @hsheth2