Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lineage): add priority to via node #10034

Merged
merged 18 commits into from
Mar 16, 2024

Conversation

RyanHolstien
Copy link
Collaborator

Updates edge key to include lifecycle owner, impacts document ids for graph service. Should not need backfill or extra removal to handle, but may result in extra edges being stored. Edges should be removed as normal and should not impact final search results with duplicates removed.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@RyanHolstien RyanHolstien self-assigned this Mar 12, 2024
@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Mar 12, 2024
@RyanHolstien RyanHolstien added platform PR-s that make changes to core parts of the platform and removed ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX labels Mar 12, 2024
@@ -457,7 +462,7 @@ private List<LineageRelationship> getLineageRelationships(
}

@VisibleForTesting
public static QueryBuilder getLineageQuery(
public QueryBuilder getLineageQuery(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static removed to make it easier to test?

@RyanHolstien RyanHolstien merged commit 84bdf81 into datahub-project:master Mar 16, 2024
60 checks passed
@RyanHolstien RyanHolstien deleted the feat/viaNodePriority branch March 18, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment platform PR-s that make changes to core parts of the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants