-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lineage): add priority to via node #10034
Merged
RyanHolstien
merged 18 commits into
datahub-project:master
from
RyanHolstien:feat/viaNodePriority
Mar 16, 2024
Merged
feat(lineage): add priority to via node #10034
RyanHolstien
merged 18 commits into
datahub-project:master
from
RyanHolstien:feat/viaNodePriority
Mar 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
PR or Issue related to the ingestion of metadata
product
PR or Issue related to the DataHub UI/UX
devops
PR or Issue related to DataHub backend & deployment
labels
Mar 12, 2024
RyanHolstien
added
platform
PR-s that make changes to core parts of the platform
and removed
ingestion
PR or Issue related to the ingestion of metadata
product
PR or Issue related to the DataHub UI/UX
labels
Mar 12, 2024
@@ -457,7 +462,7 @@ private List<LineageRelationship> getLineageRelationships( | |||
} | |||
|
|||
@VisibleForTesting | |||
public static QueryBuilder getLineageQuery( | |||
public QueryBuilder getLineageQuery( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Static removed to make it easier to test?
david-leifker
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates edge key to include lifecycle owner, impacts document ids for graph service. Should not need backfill or extra removal to handle, but may result in extra edges being stored. Edges should be removed as normal and should not impact final search results with duplicates removed.
Checklist