Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/databricks): support hive metastore schemas with special char #10049

Merged
merged 5 commits into from
Mar 27, 2024
Merged

fix(ingest/databricks): support hive metastore schemas with special char #10049

merged 5 commits into from
Mar 27, 2024

Conversation

mayurinehate
Copy link
Collaborator

Also adds

  • exception handling to some scopes limit impact on rest of ingestion
  • more details on unity-catalog source

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@mayurinehate
fix(ingest/databricks): support hive metastore schemas with special c…
02daf29 
…hars

Also adds
- exception handling to some scopes limit impact on rest of ingestion
- more details on unity-catalog source
@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Mar 14, 2024
hsheth2
hsheth2 reviewed Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks good

metadata-ingestion/docs/sources/databricks/README.md Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/unity/hive_metastore_proxy.py Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/unity/usage.py Outdated Show resolved Hide resolved
@samblackk samblackk removed the community-contribution PR or Issue raised by member(s) of DataHub Community label Mar 19, 2024
@mayurinehate mayurinehate requested a review from hsheth2 March 27, 2024 07:35
@hsheth2 hsheth2 merged commit 9928d70 into datahub-project:master Mar 27, 2024
56 of 57 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@mayurinehate @sleeperdeep
fix(ingest/databricks): support hive metastore schemas with special c…
349a20a 
…har (datahub-project#10049)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayurinehate @hsheth2 @samblackk